Repository navigation
DEV-1115 Refuse a 'local' publish; add job timeouts - #126
Merged
JongChern merged 1 commit intoOct 18, 2026
Merged
Conversation
Re-enabling the publishing block means a hand-run `gradlew publish` without -PreleaseVersion would push version 'local' to GitHub Packages, where it can never be overwritten; developers already keep gpr.key in GRADLE_USER_HOME for reading the driver. Publishing to a remote repository now refuses 'local'; publishToMavenLocal is unaffected. Add job timeouts so a hung Gradle daemon cannot hold a runner for the default 6 hours (as happened to the CI run on #124). Co-Authored-By: Claude Opus 5.5 <[email protected]>
JongChern
added a commit
that referenced
this pull request
Oct 18, 2026
Three follow-ups ahead of review: - The release build job now also builds every example app against the driver this release ships with, before anything is published. ci.yml only ever builds them against master's default driver, so a release that picks a newer driver was never built with the examples (raised in #126). Both build steps pass the 4 GB daemon heap from #125. - The publishing block accepts gpr.usr as well as gpr.user, since the root build.gradle reads gpr.usr (also raised in #126). - actions/* steps are pinned to commit SHAs, matching #124: each is the commit its v4 tag points at today. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes found while testing #123. This PR targets
DEV-1115_release_workflow, so merging it folds the fixes into #123.1. Refuse to publish version
local#123 turns the publishing block back on. Without
-PreleaseVersionits version islocal, and developers already keepgpr.keyin~/.gradle/gradle.propertiesto read the driver. So a hand-rungradlew publishwould pushlocalto GitHub Packages, which can never overwrite that version. Publishing to a remote repository now fails in that case.publishToMavenLocalis unaffected.2. Job timeouts
30 minutes on the build job and 10 on the release job. A hung Gradle daemon on #124 held a runner for 6 hours.
Tested locally (JDK 17)
:ShimmerAndroidInstrumentDriver:assembleRelease -PdriverVersion=0.11.7_betabuilds the 1.3 MB.aar.-PreleaseVersion, it fails with the new message.-PreleaseVersion=0.0.0_test, it writes the.aarand POM.Also checked on #123 as it stands: the version-and-driver step, run against the real tags and releases.
3.2.10_betaagainst driver0.11.8_beta.0.11.7_beta.3.2.9_betais refused (it exists asAndroidAPI_v3.2.9Beta).3.2.8_betais refused (it exists asv3.2.8Beta).9.9.9is refused, even on a dry run.Not changed here, for the author
0.11.7_beta). The combination that ships is never built with the examples.gpr.user, but the read repositories in the rootbuild.gradlereadgpr.usr.🤖 Generated with Claude Code